Repository navigation
fix(signing): use public httpcore2 socket option type on main - #1922
Merged
rachitm022 merged 2 commits intoNov 17, 2026
Merged
Conversation
rachitm022
requested review from
KonstantinMirin and
bokelley
as code owners
November 17, 2026 06:18
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — clean PR, no blocking or medium findings.
Checked:
src/adcp/signing/ip_pinned_transport.pymoves aTYPE_CHECKING-onlySOCKET_OPTION2import from the privatehttpcore2._backends.basepath to the publichttpcore2top-level. No runtime effect, more stable import shape, mypy-guarded.tests/conformance/signing/test_ip_pinned_transport.pynarrows the contract test from fullinspect.signatureequality to a (name, kind, default) comparison, dropping only annotation parity. Since the override delegates via fixed kwargs, call-compatibility is still verified and the signature-drift guard stays armed — the CI gate is not disabled.
Decision path: high_risk is true via src/adcp/signing/** (modified), but the reviewer found no medium-or-higher concerns, so the modification is presumed safe (row 5 does not fire). gated_paths is false (row 2 N/A). No no-auto-approve team match. Zero findings, so rows 1, 3–8 do not apply → row 9 approve. Note: review_decision is REVIEW_REQUIRED, but that only blocks approval when gated_paths is true, which it is not here.
rachitm022
deleted the
rachitm022/backport-httpcore2-socket-option-main
branch
November 17, 2026 07:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mainfails repo-wide mypy becausehttpcore2==2.16.1no longer explicitly exportsSOCKET_OPTIONfrom its private_backends.basemodule. This also blocks the Python 3.12 CI job on #1921.The same fix was already reviewed and merged into
nextin #1916. No open PR currently changessrc/adcp/signing/ip_pinned_transport.pyonmain; this PR brings that fix to the branch whose CI is failing.What changed
httpcore2package export and its backend contract test from fix(signing): use public httpcore2 socket option type #1916.Verification
origin/mainbefore the backport.uv run --extra dev mypy src/adcp/ packages/adcp-reporting-storage/src/adcp_reporting_storage/— 1,555 source files, no issues.uv run --extra dev -m pytest tests/conformance/signing/test_ip_pinned_transport.py -q— 393 passed.git diff --checkpassed.